Add ZeroThresholds test in Blocks #4229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobolar
added
the
L: ModelicaTest
HansOlsson
reviewed
Jan 12, 2024
Co-authored-by: Hans Olsson <HansOlsson@users.noreply.github.com>
HansOlsson
approved these changes
Jan 12, 2024
There was a problem hiding this comment.
Looking good.
I can understand that it slightly complicated to handle since it is exactly at the threshold.
However, there should be no integration uncertainty in the ramp and limiter combination (there is neither a differential equation nor a non-linear system) and during events such expressions should be used as is:
https://specification.modelica.org/maint/3.6/equations.html#events-and-synchronization
(Note: That's an oversimplification in some advanced cases.)
If we wanted to ignore such differences it wouldn't make sense to have both greater and greaterequal blocks.
MartinOtter
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a test example addressing both
Modelica.Blocks.Nonlinear.LimiterandModelica.Blocks.Logical.GreaterThresholddue to OpenModelica/OpenModelica#11132Note: OM gives resuts different to Dymola and ModelonImpact.