Add computed attribute #1679
Merged
Add computed attribute #1679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds functions setShiftDecimal and setShifCounter, update text.
Maked intervalDecimal mandatory for constant fixed and tunable clocks, make interval counter optional
and remove "fixedComputed" and "tunableComputed"
KarlWernersson
requested changes
Feb 17, 2022
| <xs:enumeration value="tunable"/> | ||
| <xs:enumeration value="changing"/> |
There was a problem hiding this comment.
Does the removal of changing originate from my PR?
It that case I belive it was a mistake
There was a problem hiding this comment.
I added that back into your initial PR - @t-sommer must rebase his proposal, I guess...
|
@KarlWernersson : would you accept @t-sommer changes on top of yours? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.