Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MPFE-1068] ModeraServerCrudBundle: proper pagination fetch for complex queries #26

Merged
merged 2 commits into from
Jul 9, 2018

Conversation

cravler
Copy link
Member

@cravler cravler commented Jul 3, 2018

For tests:

Actions.ModeraBackendTranslationsTool_Translations.list({
    page: 1,
    start: 0,
    limit: 25,
    hydration: { profile: "list" },
    filter: [
        [
            { property: "domain", value: "eq:user" },
            { property: "tokenName", value: "like:%user%" }, 
            { property: "languageTranslationTokens.translation", value: "like:%user%" }
        ]
    ]
}, ({items, total}) => console.log({ items: items.length, total }));

Before fix:

{ items: 9, total: "61" }

After fix:

{ items: 25, total: 61 }

@sergeil
Copy link
Contributor

sergeil commented Jul 3, 2018

Tests are missing.

@sergeil sergeil merged commit aba8477 into master Jul 9, 2018
@cravler cravler deleted the crub_pagination_fetch_fix branch July 9, 2018 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants