[MPFE-1005] User manager > deactivate function #7
Conversation
|
Please also update composer.json so it would include "dev-master" version of "modera/mjr" package, as this new feature requires functionality added in 0.5.0 version of MJR which is not released yet. If no problems are found then during next weekend I will release MJR 0.5.0 and 2.55.0 of foundation so everybody so other project can also update to a stable version. |
| @@ -40,6 +48,27 @@ Ext.define('Modera.backend.security.toolscontribution.runtime.user.ListActivity' | |||
| me.fireEvent('handleaction', 'edit-groups', sourceComponent, params); | |||
| }); | |||
|
|
|||
| ui.on('enableprofile', function(sourceComponent, params) { | |||
There was a problem hiding this comment.
Please move 'enableprofile' and 'disableprofile' listeners to template method called "attachListeners". "attachContractListeners" by convention is used for setting to set-up inter-activity interaction listeners only.
For more details read this:
| @@ -73,12 +73,26 @@ public function getConfig() | |||
| 'firstName' => $user->getFirstName(), | |||
| 'lastName' => $user->getLastName(), | |||
| 'middleName' => $user->getMiddleName(), | |||
| 'isActive' => $user->getIsActive(), | |||
There was a problem hiding this comment.
Though method "setIsActive" and "getIsActive" were introduced in a scope of other commit it doesn't exactly follow proper mutator method names convention, instead it is preferred to have names such as "setActive" and "isActive" for boolean getter/setter pairs, please add @deprecated annotation to both setIsActive/getIsActive methods in User class and add proper ones (isActive, setActive) instead.
No description provided.