Do not resolve multiple times outside root files

.changeset/healthy-lizards-attack.md

@@ -0,0 +1,6 @@
+---
+"@web/dev-server-rollup": patch
+"@web/dev-server": patch
+---
+
+do not resolve multiple times outside root files

packages/dev-server-rollup/src/rollupAdapter.ts

@@ -21,7 +21,7 @@ import { CustomPluginOptions, Plugin as RollupPlugin, TransformPluginContext } f
 import { InputOptions } from 'rollup';
 import { red, cyanBright } from 'chalk';
 
-import { toBrowserPath, isAbsoluteFilePath } from './utils';
+import { toBrowserPath, isAbsoluteFilePath, isOutsideRootDir } from './utils';
 import { createRollupPluginContextAdapter } from './createRollupPluginContextAdapter';
 import { createRollupPluginContexts, RollupPluginContexts } from './createRollupPluginContexts';
 
@@ -196,6 +196,11 @@ export function rollupAdapter(
           return `${resolvedImportPath}`;
         }
 
+        // file already resolved outsided root dir
+        if (isOutsideRootDir(resolvedImportPath)) {
+          return `${resolvedImportPath}`;
+        }
+
         const normalizedPath = path.normalize(resolvedImportPath);
         if (!normalizedPath.startsWith(rootDir)) {
           const relativePath = path.relative(rootDir, normalizedPath);

packages/dev-server-rollup/src/utils.ts

@@ -14,3 +14,7 @@ export function toBrowserPath(filePath: string) {
 export function isAbsoluteFilePath(path: string) {
   return REGEXP_ABSOLUTE.test(path);
 }
+
+export function isOutsideRootDir(path: string) {
+  return path.startsWith('/__wds-outside-root__/');
+}

packages/dev-server-rollup/test/node/fixtures/resolve-outside-dir/src/app.js

@@ -0,0 +1,3 @@
+import moduleA from 'module-a';
+
+console.log(moduleA);

packages/dev-server-rollup/test/node/plugins/node-resolve.test.ts

@@ -1,11 +1,14 @@
+import path from 'path';
 import rollupNodeResolve from '@rollup/plugin-node-resolve';
+import rollupCommonjs from '@rollup/plugin-commonjs';
 import fetch from 'node-fetch';
 
 import { createTestServer, fetchText, expectIncludes } from '../test-helpers';
 import { fromRollup } from '../../../src/index';
 import { expect } from 'chai';
 
 const nodeResolve = fromRollup(rollupNodeResolve, {}, { throwOnUnresolvedImport: true });
+const commonjs = fromRollup(rollupCommonjs);
 
 describe('@rollup/plugin-node-resolve', () => {
   it('can resolve imports', async () => {
@@ -79,4 +82,38 @@ describe('@rollup/plugin-node-resolve', () => {
       server.stop();
     }
   });
+
+  it('node modules resolved outside root directory are rewritten', async () => {
+    const { server, host } = await createTestServer({
+      rootDir: path.resolve(__dirname, '..', 'fixtures', 'resolve-outside-dir', 'src'),
+      plugins: [nodeResolve()],
+    });
+
+    try {
+      const responseText = await fetchText(`${host}/app.js`);
+      expectIncludes(
+        responseText,
+        "import moduleA from '/__wds-outside-root__/1/node_modules/module-a/index.js'",
+      );
+    } finally {
+      server.stop();
+    }
+  });
+
+  it('node modules resolved outside root directory are rewritten with commonjs', async () => {
+    const { server, host } = await createTestServer({
+      rootDir: path.resolve(__dirname, '..', 'fixtures', 'resolve-outside-dir', 'src'),
+      plugins: [commonjs(), nodeResolve()],
+    });
+
+    try {
+      const responseText = await fetchText(`${host}/app.js`);
+      expectIncludes(
+        responseText,
+        "import moduleA from '/__wds-outside-root__/1/node_modules/module-a/index.js'",
+      );
+    } finally {
+      server.stop();
+    }
+  });
 });