Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not resolve multiple times outside root files #1382

Conversation

edoardocavazza
Copy link
Contributor

Right now, files outside the root dir are not correctly served when using a rollup plugin in combination with the node resolve option. Multiple resolveImport passes result in /__wds-outside-root__/<n>/__wds-outside-root__/<n>/<module>/<file>.

What I did

  1. Added a check for already resolved files outside the rootDir

@changeset-bot
Copy link

changeset-bot bot commented Apr 8, 2021

🦋 Changeset detected

Latest commit: 89ba7cf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@web/dev-server-rollup Patch
@web/dev-server Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@LarsDenBakker LarsDenBakker merged commit 0a05464 into modernweb-dev:master Apr 8, 2021
@LarsDenBakker
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants