You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since version 0.4.0, es-module-lexer exposes a n property for each import specifier with its unescaped source. This is useful (and more accurate) for virtual modules like \0commonHelpers.
What I did
try to use the n property of the specifier, fallback to the previous version if missing.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
This is interesting.. but in the @web/dev-server-rollup we already handle these null character. Could you elaborate which use case this fixes? Also can JS handle the unescaped import characters?
I'm not sure that's the case, we transform the import to a whole different import. Do you see that this change fixes a specific problem? What I saw in the past was that the null character would be sent to the browser but not sent back in the request URL.. making it useless.
Hello @LarsDenBakker, I added an unit test with the use case. If you revert the proposed fix, you can see that null character is not handled after esbuild transformation.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
edoardocavazza
force-pushed
the
fix/escaped-import-specifiers
branch
from
Since version 0.4.0,
es-module-lexerexposes anproperty for each import specifier with its unescaped source. This is useful (and more accurate) for virtual modules like\0commonHelpers.What I did
nproperty of the specifier, fallback to the previous version if missing.