-
-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: reenable all tests and update snapshots #2370
Conversation
|
packages/rollup-plugin-polyfills-loader/test/snapshots/flattened.html
Outdated
Show resolved
Hide resolved
If we don't come up with a quick solution to this, we can look into disabling these tests again temporarily in order to get all the tests running again on |
@thepassle here is a proposal to fix the "random" timeouts. Locally it works. Let's see if it works correctly in a pipeline. |
997dfc5
to
04e0bd7
Compare
return loadScript('./entrypoint-b.js', 'module', []); | ||
}, function () { | ||
return loadScript('./entrypoint-a.js', 'module', []); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmmm I'm just wondering is the order here maybe wrong?
as it's now entrypoint-b
and then entrypoint-a
🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think the order matters here?
This is looking green except for the windows tests hanging, which I believe is a separate issue. |
Took a first look at the Windows pipeline. Seemed to be hanging once wireit starts the |
04e0bd7
to
3ef40f8
Compare
3ef40f8
to
c5ba1d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty good to me! I'm not sure on the snapshot tests but I'm not sure if the order matters.
@@ -4,6 +4,7 @@ on: pull_request | |||
|
|||
jobs: | |||
verify-windows: | |||
timeout-minutes: 30 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that we have a timeout now. I'd argue that we can probably make it even lower but maybe in a future PR.
So is this an issue with wireit? It seems unlikely that its an issue with TSC, right? Should we disable wireit for now, and just run TSC directly? What do you think @daKmoR ? |
19b5d00
to
6544b78
Compare
web/packages/mocks/package.json Line 41 in 6544b78
|
6544b78
to
f0eae22
Compare
Now this is happening without wireit! 🤔
|
Maybe we can enable the I googled around and someone talked about this happening on machines with lower memory and I did discover that the Windows machines have 7GB memory while macOS has 14GB which might explain why it would only hang on Windows machines. https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners |
f0eae22
to
4c331b2
Compare
ok, I now specifically NOT do the types action on windows (there is no need to do it anyways) still there is one failing test... but I will leave this for another PR |
What I did