Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Series.pop() doesn`t work correctly at MODIN_STORAGE_FORMAT=omnisci #4100

Closed
Rubtsowa opened this issue Jan 28, 2022 · 1 comment · Fixed by #4937
Closed

Series.pop() doesn`t work correctly at MODIN_STORAGE_FORMAT=omnisci #4100

Rubtsowa opened this issue Jan 28, 2022 · 1 comment · Fixed by #4937
Labels
bug 🦗 Something isn't working HDK Related to HDK (OmniSci successor) engine or backend P3 Very minor bugs, or features we can hopefully add some day. pandas concordance 🐼 Functionality that does not match pandas

Comments

@Rubtsowa
Copy link
Contributor

When I run:

import modin.pandas as pd
from modin.pandas.test.utils import test_data_values
import modin.config as cfg
cfg.StorageFormat.put('omnisci')

data = test_data_values[0]
modin_series = pd.Series(data[next(iter(data.keys()))])
for key in modin_series.keys():
    modin_series.pop(key)

I have error:

AssertionError: Only column drop is supported
@Rubtsowa Rubtsowa added bug 🦗 Something isn't working HDK Related to HDK (OmniSci successor) engine or backend labels Jan 28, 2022
@Rubtsowa Rubtsowa mentioned this issue Jan 28, 2022
Closed
@vnlitvinov vnlitvinov added P3 Very minor bugs, or features we can hopefully add some day. pandas concordance 🐼 Functionality that does not match pandas labels Aug 29, 2022
@vnlitvinov
Copy link
Collaborator

@modin-project/modin-omnisci could someone please check if this still happens?

@AndreyPavlenko AndreyPavlenko mentioned this issue Sep 6, 2022
Merged
8 tasks
AndreyPavlenko added a commit to AndreyPavlenko/modin that referenced this issue Nov 22, 2022
@AndreyPavlenko
FIX-modin-project#4100: Fall back to Pandas on row drop
d90006e 
Only column drop is currently supported by the omnisci engine.

Signed-off-by: Andrey Pavlenko <andrey.a.pavlenko@gmail.com>
YarShev added a commit that referenced this issue Nov 22, 2022
@AndreyPavlenko @YarShev
FIX-#4100: Fall back to Pandas on row drop (#4937)
e639418 
Co-authored-by: Iaroslav Igoshev <Poolliver868@mail.ru>
Signed-off-by: Andrey Pavlenko <andrey.a.pavlenko@gmail.com>
dchigarev pushed a commit that referenced this issue Nov 25, 2022
@AndreyPavlenko @YarShev @dchigarev
FIX-#4100: Fall back to Pandas on row drop (#4937)
d1cf2be 
Co-authored-by: Iaroslav Igoshev <Poolliver868@mail.ru>
Signed-off-by: Andrey Pavlenko <andrey.a.pavlenko@gmail.com>
@AndreyPavlenko AndreyPavlenko mentioned this issue Dec 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🦗 Something isn't working HDK Related to HDK (OmniSci successor) engine or backend P3 Very minor bugs, or features we can hopefully add some day. pandas concordance 🐼 Functionality that does not match pandas
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FIX-#4100: Fall back to Pandas on row drop AndreyPavlenko/modin
2 participants
@Rubtsowa @vnlitvinov