Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX-#4100: Fall back to Pandas on row drop #4937

Merged
merged 2 commits into from
Nov 22, 2022
Merged

FIX-#4100: Fall back to Pandas on row drop #4937

merged 2 commits into from
Nov 22, 2022

Conversation

AndreyPavlenko
Copy link
Collaborator

Signed-off-by: Andrey Pavlenko andrey.a.pavlenko@gmail.com

What do these changes do?

Only column drop is currently supported by the omnisci engine.

  • commit message follows format outlined here
  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Series.pop() doesn`t work correctly at MODIN_STORAGE_FORMAT=omnisci #4100
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date
  • added (Issue Number: PR title (PR Number)) and github username to release notes for next major release

@AndreyPavlenko AndreyPavlenko marked this pull request as ready for review September 15, 2022 18:40
@AndreyPavlenko AndreyPavlenko requested review from a team as code owners September 15, 2022 18:40
@codecov
Copy link

codecov bot commented Sep 15, 2022 •
edited

Codecov Report

Merging #4937 (3af3f35) into master (f727c04) will increase coverage by 4.73%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4937      +/-   ##
==========================================
+ Coverage   84.87%   89.61%   +4.73%     
==========================================
  Files         267      268       +1     
  Lines       19746    20030     +284     
==========================================
+ Hits        16760    17949    +1189     
+ Misses       2986     2081     -905
Impacted Files Coverage Δ
...tal/core/storage_formats/omnisci/query_compiler.py 94.51% <100.00%> (+0.01%) ⬆️
modin/logging/config.py 94.59% <0.00%> (-1.30%) ⬇️
modin/experimental/batch/test/test_pipeline.py 92.39% <0.00%> (ø)
modin/pandas/series.py 94.27% <0.00%> (+0.23%) ⬆️
modin/pandas/groupby.py 93.77% <0.00%> (+0.23%) ⬆️
modin/pandas/series_utils.py 98.89% <0.00%> (+0.55%) ⬆️
...odin/core/storage_formats/pandas/query_compiler.py 96.40% <0.00%> (+0.56%) ⬆️
modin/core/io/text/excel_dispatcher.py 94.01% <0.00%> (+0.85%) ⬆️
modin/core/io/column_stores/parquet_dispatcher.py 96.25% <0.00%> (+2.08%) ⬆️
...tations/pandas_on_python/partitioning/partition.py 93.75% <0.00%> (+2.08%) ⬆️
... and 38 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AndreyPavlenko
FIX-modin-project#4100: Fall back to Pandas on row drop
d90006e 
Only column drop is currently supported by the omnisci engine.

Signed-off-by: Andrey Pavlenko <andrey.a.pavlenko@gmail.com>
YarShev
YarShev reviewed Nov 22, 2022
View reviewed changes
Copy link
Collaborator

@YarShev YarShev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment to be more explicit.

modin/experimental/core/execution/native/implementations/hdk_on_native/test/test_dataframe.py Outdated Show resolved Hide resolved
@AndreyPavlenko @YarShev
Apply suggestions from code review
059ec90 
Co-authored-by: Iaroslav Igoshev <Poolliver868@mail.ru>
@YarShev YarShev merged commit e639418 into modin-project:master Nov 22, 2022
dchigarev pushed a commit that referenced this pull request Nov 25, 2022
@AndreyPavlenko @YarShev @dchigarev
FIX-#4100: Fall back to Pandas on row drop (#4937)
d1cf2be 
Co-authored-by: Iaroslav Igoshev <Poolliver868@mail.ru>
Signed-off-by: Andrey Pavlenko <andrey.a.pavlenko@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ienkovich ienkovich ienkovich left review comments

@YarShev YarShev YarShev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Series.pop() doesn`t work correctly at MODIN_STORAGE_FORMAT=omnisci
3 participants
@AndreyPavlenko @ienkovich @YarShev