Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement groupby.rolling API #6191

Closed
dchigarev opened this issue May 23, 2023 · 0 comments · Fixed by #6292
Closed

Implement groupby.rolling API #6191

dchigarev opened this issue May 23, 2023 · 0 comments · Fixed by #6292
Assignees
@dchigarev
Labels
new feature/request 💬 Requests and pull requests for new features P1 Important tasks that we should complete soon

Comments

@dchigarev
Copy link
Collaborator

Currently it's defaulting to pandas:

modin/modin/pandas/groupby.py

Lines 1144 to 1145 in 2a0566e

def rolling(self, *args, **kwargs):
return self._default_to_pandas(lambda df: df.rolling(*args, **kwargs))

@dchigarev dchigarev added new feature/request 💬 Requests and pull requests for new features P1 Important tasks that we should complete soon labels May 23, 2023
@dchigarev dchigarev self-assigned this May 23, 2023
dchigarev added a commit to dchigarev/modin that referenced this issue Jun 25, 2023
@dchigarev
FEAT-modin-project#6191: First draft of 'groupby.rolling' implementation
60abc98 
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
@dchigarev dchigarev mentioned this issue Jun 26, 2023
Merged
7 tasks
anmyachev pushed a commit that referenced this issue Jun 29, 2023
@dchigarev
FEAT-#6191: Implement groupby.rolling API (#6292)
e6b79c9 
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dchigarev dchigarev

Labels
new feature/request 💬 Requests and pull requests for new features P1 Important tasks that we should complete soon
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FEAT-#6191: Implement groupby.rolling API dchigarev/modin
1 participant
@dchigarev