Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename read_pickle_distributed/to_pickle_distributed to read_pickle_glob/to_pickle_glob #6856

Closed
anmyachev opened this issue Jan 12, 2024 · 2 comments · Fixed by #6957
Closed
Labels
Code Quality 💯 Improvements or issues to improve quality of codebase P2 Minor bugs or low-priority feature requests pandas.io

Comments

@anmyachev
Copy link
Collaborator

For consistency with other functions like read_csv_glob and read_parquet_glob.

@anmyachev anmyachev added Code Quality 💯 Improvements or issues to improve quality of codebase P2 Minor bugs or low-priority feature requests labels Jan 12, 2024
@npochhi
Copy link

npochhi commented Jan 16, 2024

Hi 👋, I'd like to work on this simple issue if it's alright with you.

@YarShev
Copy link
Collaborator

YarShev commented Jan 16, 2024

Hi @npochhi, it would be great if you could help us with this. Please note that this is not a simple renaming. We should also preserve backward compatibility for a few future Modin releases. You can open a PR where we discuss more.

anmyachev added a commit to anmyachev/modin that referenced this issue Feb 22, 2024
…_distributed to read_pickle_glob/to_pickle_glob

Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
anmyachev added a commit to anmyachev/modin that referenced this issue Feb 22, 2024
…_distributed to read_pickle_glob/to_pickle_glob

Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
YarShev pushed a commit that referenced this issue Feb 23, 2024
…to read_pickle_glob/to_pickle_glob (#6957)

Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Quality 💯 Improvements or issues to improve quality of codebase P2 Minor bugs or low-priority feature requests pandas.io
Projects
None yet
3 participants