FEAT-#6832: Implement read_xml_glob, to_xml_glob #6930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
anmyachev
requested review from
devin-petersohn,
mvashishtha,
RehanSD,
YarShev,
vnlitvinov,
dchigarev and
a team
as code owners
YarShev
reviewed
Feb 13, 2024
| @@ -44,6 +44,7 @@ | |||
| read_parquet_glob, | |||
| read_pickle_distributed, | |||
| read_sql, | |||
| read_xml_glob, | |||
| to_pickle_distributed, | |||
There was a problem hiding this comment.
Do we have an issue to remove the deprecated to_pickle_distributed?
There was a problem hiding this comment.
It would be great to deprecate it already in this release.
YarShev
previously approved these changes
Feb 13, 2024
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
YarShev
reviewed
Feb 13, 2024
| def test_to_xml(): | ||
| # `lxml` is a required dependency for `to_xml`, but optional for Modin. | ||
| # For some engines we do not install it (like for HDK). | ||
| pytest.importorskip("lxml") |
There was a problem hiding this comment.
Why can't we add it to development dependencies?
There was a problem hiding this comment.
We can, but it's not strictly necessary. I don’t really want to complicate HDK environment, since it has the same code used for defaulting into pandas.
There was a problem hiding this comment.
I don't think we will complicate HDK env with a new dep. Maybe we could do this in a separate issue.
YarShev
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.pyblack --check modin/ asv_bench/benchmarks scripts/doc_checker.pygit commit -sread_xml_glob#6832docs/development/architecture.rstis up-to-date