Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor _get_dimensions introduced in #6841 #6858

Closed
arunjose696 opened this issue Jan 15, 2024 · 0 comments · Fixed by #6859
Closed

Refactor _get_dimensions introduced in #6841 #6858

arunjose696 opened this issue Jan 15, 2024 · 0 comments · Fixed by #6859

Comments

@arunjose696
Copy link
Collaborator

arunjose696 commented Jan 15, 2024 •
edited

Refactor _get_dimensions function by following below steps

Rename _get_dimensions to _get_lengths,
remove the string parameter passed to _get_dimensions and instead use axis as the argument to the function.
Rename check_is_future function in partiton manager to is_future.
@arunjose696 arunjose696 mentioned this issue Jan 15, 2024
Merged
7 tasks
YarShev pushed a commit that referenced this issue Jan 16, 2024
@arunjose696
REFACTOR-#6858: Rename _get_dimensions and change arguments (#6859)
43134ef 
Signed-off-by: arunjose696 <arunjose696@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

REFACTOR-#6858: Rename _get_dimensions and change arguments arunjose696/modin
1 participant
@arunjose696