Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACTOR-#6858: Rename _get_dimensions and change arguments #6859

Merged
merged 1 commit into from Jan 16, 2024

Conversation

arunjose696
Copy link
Collaborator

@arunjose696 arunjose696 commented Jan 15, 2024

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Refactor _get_dimensions introduced in #6841 #6858 6858
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

Copy link
Collaborator

@YarShev YarShev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arunjose696, can you modify the commit message to follow the rules and sign up it?

Signed-off-by: arunjose696 <arunjose696@gmail.com>
@arunjose696
Copy link
Collaborator Author

@arunjose696, can you modify the commit message to follow the rules and sign up it?

Done.

@YarShev YarShev merged commit 43134ef into modin-project:master Jan 16, 2024
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor _get_dimensions introduced in #6841
2 participants