Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not force materialization in MetaList.__getitem__() #7001

Closed
AndreyPavlenko opened this issue Mar 4, 2024 · 0 comments · Fixed by #7006
Closed

Do not force materialization in MetaList.__getitem__() #7001

AndreyPavlenko opened this issue Mar 4, 2024 · 0 comments · Fixed by #7006
Labels
new feature/request 💬 Requests and pull requests for new features Ray ⚡ Issues related to the Ray engine

Comments

@AndreyPavlenko
Copy link
Collaborator

This operation is widely used and the materialization here has a negative performance impact.
See #6948 (comment)
@AndreyPavlenko AndreyPavlenko added new feature/request 💬 Requests and pull requests for new features Ray ⚡ Issues related to the Ray engine labels Mar 4, 2024
@AndreyPavlenko AndreyPavlenko mentioned this issue Mar 4, 2024
Closed
AndreyPavlenko added a commit to AndreyPavlenko/modin that referenced this issue Mar 4, 2024
@AndreyPavlenko
FEAT-modin-project#7001: Do not force materialization in MetaList.__g…
36c02dd 
…etitem__()

Signed-off-by: Andrey Pavlenko <andrey.a.pavlenko@gmail.com>
AndreyPavlenko added a commit to AndreyPavlenko/modin that referenced this issue Mar 4, 2024
@AndreyPavlenko
FEAT-modin-project#7001: Do not force materialization in MetaList.__g…
4828c74 
…etitem__()

Signed-off-by: Andrey Pavlenko <andrey.a.pavlenko@gmail.com>
AndreyPavlenko added a commit to AndreyPavlenko/modin that referenced this issue Mar 4, 2024
@AndreyPavlenko
FEAT-modin-project#7001: Do not force materialization in MetaList.__g…
0037599 
…etitem__()

Signed-off-by: Andrey Pavlenko <andrey.a.pavlenko@gmail.com>
@AndreyPavlenko AndreyPavlenko mentioned this issue Mar 4, 2024
Merged
7 tasks
AndreyPavlenko added a commit to AndreyPavlenko/modin that referenced this issue Mar 4, 2024
@AndreyPavlenko
FEAT-modin-project#7001: Do not force materialization in MetaList.__g…
2f1b6a2 
…etitem__()

Signed-off-by: Andrey Pavlenko <andrey.a.pavlenko@gmail.com>
AndreyPavlenko added a commit to AndreyPavlenko/modin that referenced this issue Mar 5, 2024
@AndreyPavlenko
FEAT-modin-project#7001: Do not force materialization in MetaList.__g…
d9c4ead 
…etitem__()

Signed-off-by: Andrey Pavlenko <andrey.a.pavlenko@gmail.com>
AndreyPavlenko added a commit to AndreyPavlenko/modin that referenced this issue Mar 5, 2024
@AndreyPavlenko
FEAT-modin-project#7001: Do not force materialization in MetaList.__g…
3edf4b6 
…etitem__()

Signed-off-by: Andrey Pavlenko <andrey.a.pavlenko@gmail.com>
AndreyPavlenko added a commit to AndreyPavlenko/modin that referenced this issue Mar 5, 2024
@AndreyPavlenko
FEAT-modin-project#7001: Do not force materialization in MetaList.__g…
ae05a5a 
…etitem__()

Signed-off-by: Andrey Pavlenko <andrey.a.pavlenko@gmail.com>
YarShev pushed a commit that referenced this issue Mar 6, 2024
@AndreyPavlenko @dchigarev
FEAT-#7001: Do not force materialization in MetaList.__getitem__() (#…
7a5919e 
…7006)

Co-authored-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
Signed-off-by: Andrey Pavlenko <andrey.a.pavlenko@gmail.com>
anmyachev pushed a commit to anmyachev/modin that referenced this issue Mar 6, 2024
@AndreyPavlenko @dchigarev @anmyachev
FEAT-modin-project#7001: Do not force materialization in MetaList.__g…
47a886c 
…etitem__() (modin-project#7006)

Co-authored-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
Signed-off-by: Andrey Pavlenko <andrey.a.pavlenko@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
new feature/request 💬 Requests and pull requests for new features Ray ⚡ Issues related to the Ray engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FEAT-#7001: Do not force materialization in MetaList.__getitem__() AndreyPavlenko/modin
1 participant
@AndreyPavlenko