FEAT-#7001: Do not force materialization in MetaList.__getitem__() #7006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
AndreyPavlenko
force-pushed
the
issue-7001
branch
2 times, most recently
from
2f1b6a2
to
d9c4ead
Compare
modin/core/execution/ray/implementations/pandas_on_ray/partitioning/partition.py
Fixed
Show fixed
Hide fixed
AndreyPavlenko
force-pushed
the
issue-7001
branch
from
d9c4ead
to
3edf4b6
Compare
…etitem__() Signed-off-by: Andrey Pavlenko <andrey.a.pavlenko@gmail.com>
AndreyPavlenko
force-pushed
the
issue-7001
branch
from
3edf4b6
to
ae05a5a
Compare
AndreyPavlenko
requested review from
devin-petersohn,
mvashishtha,
RehanSD,
YarShev,
vnlitvinov,
anmyachev,
dchigarev and
a team
as code owners
YarShev
reviewed
Mar 5, 2024
modin/core/execution/ray/implementations/pandas_on_ray/partitioning/partition.py
Outdated
Show resolved
Hide resolved
YarShev
reviewed
Mar 5, 2024
YarShev
reviewed
Mar 5, 2024
| obj = self.meta._obj | ||
| return obj[self.idx] if isinstance(obj, list) else obj | ||
|
|
||
| def map(self, materialized): |
There was a problem hiding this comment.
I am kind of confused why this method is named map. Can you elaborate?
There was a problem hiding this comment.
The main idea is to apply some calculation to a single materialized object and get one or multiple values. List with lengths is mapped to multiple lengths with MetaListMapper. Length is mapped to a different length with SlicedLenMapper.
If it's confusing, I let's rename it fo, for example, transfrom.
There was a problem hiding this comment.
Renamed to MaterializationHook.
YarShev
reviewed
Mar 5, 2024
YarShev
previously approved these changes
Mar 5, 2024
|
@dchigarev, any comments? |
dchigarev
reviewed
Mar 6, 2024
modin/core/execution/ray/implementations/pandas_on_ray/partitioning/partition.py
Show resolved
Hide resolved
Co-authored-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
dchigarev
approved these changes
Mar 6, 2024
YarShev
approved these changes
Mar 6, 2024
anmyachev
pushed a commit
to anmyachev/modin
that referenced
this pull request
Mar 6, 2024
…etitem__() (modin-project#7006) Co-authored-by: Dmitry Chigarev <dmitry.chigarev@intel.com> Signed-off-by: Andrey Pavlenko <andrey.a.pavlenko@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.pyblack --check modin/ asv_bench/benchmarks scripts/doc_checker.pygit commit -sdocs/development/architecture.rstis up-to-date