Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove check_exception_type argument of eval_general function #7008

Closed
anmyachev opened this issue Mar 5, 2024 · 0 comments · Fixed by #7009
Closed

Remove check_exception_type argument of eval_general function #7008

anmyachev opened this issue Mar 5, 2024 · 0 comments · Fixed by #7009
Assignees
@anmyachev
Labels
Code Quality 💯 Improvements or issues to improve quality of codebase Testing 📈 Issues related to testing

Comments

@anmyachev
Copy link
Collaborator

Using it not only eliminates exception checking, but also implicitly eliminates running on modin, this approach is error prone.
@anmyachev anmyachev added Code Quality 💯 Improvements or issues to improve quality of codebase Testing 📈 Issues related to testing labels Mar 5, 2024
@anmyachev anmyachev self-assigned this Mar 5, 2024
anmyachev added a commit to anmyachev/modin that referenced this issue Mar 5, 2024
@anmyachev
REFACTOR-modin-project#7008: Remove 'check_exception_type' argument o…
75aec40 
…f 'eval_general' function

Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev anmyachev mentioned this issue Mar 5, 2024
Merged
7 tasks
YarShev pushed a commit that referenced this issue Mar 6, 2024
@anmyachev
REFACTOR-#7008: Remove check_exception_type argument of `eval_gener…
8cd2bba 
…al` function (#7009)

Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anmyachev anmyachev

Labels
Code Quality 💯 Improvements or issues to improve quality of codebase Testing 📈 Issues related to testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

REFACTOR-#7008: Remove check_exception_type argument of eval_general function anmyachev/modin
1 participant
@anmyachev