REFACTOR-#7008: Remove check_exception_type argument of eval_general function
#7009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f 'eval_general' function Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
anmyachev
commented
Mar 5, 2024
| @@ -643,7 +655,22 @@ def test_pivot(data, index, columns, values): | |||
| pytest.param("nunique", id="full_axis_func"), | |||
| ], | |||
| ) | |||
| def test_pivot_table_data(data, index, columns, values, aggfunc): | |||
| def test_pivot_table_data(data, index, columns, values, aggfunc, request): | |||
| if ( | |||
There was a problem hiding this comment.
It’s not pretty, but it’s difficult to select the desired condition through parameters. It is also possible that there are several problems that will need to be investigated separately.
anmyachev
commented
Mar 5, 2024
Comment on lines
-894
to
-895
| if check_exception_type is None: | ||
| return None |
There was a problem hiding this comment.
This is the source of hidden problems.
anmyachev
commented
Mar 5, 2024
Comment on lines
+898
to
+902
| assert isinstance( | ||
| md_e, type(pd_e) | ||
| ), "Got Modin Exception type {}, but pandas Exception type {} was expected".format( | ||
| type(md_e), type(pd_e) | ||
| ) |
There was a problem hiding this comment.
By default, the exception type is assumed to be the same. Situations where this is not the case should be handled using pytest.xfail.
anmyachev
requested review from
aregm,
gshimansky,
ienkovich,
Garra1980,
YarShev,
vnlitvinov,
dchigarev,
AndreyPavlenko,
a team,
devin-petersohn,
mvashishtha and
RehanSD
as code owners
YarShev
reviewed
Mar 6, 2024
| "index", [lambda df: df.columns[0], lambda df: df[df.columns[0]].values, None] | ||
| "index", | ||
| [lambda df: df.columns[0], lambda df: df.columns[:2], lib.no_default], | ||
| ids=["one_column_index", "several_columns_index", "default"], |
There was a problem hiding this comment.
Suggested change
| ids=["one_column_index", "several_columns_index", "default"], | |
| ids=["one_column_index", "several_columns_index", "no_default"], |
?
There was a problem hiding this comment.
I can see your point, but I'm using default word here to make it clearer that this is the default value that pandas uses.
YarShev
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.pyblack --check modin/ asv_bench/benchmarks scripts/doc_checker.pygit commit -scheck_exception_typeargument ofeval_generalfunction #7008docs/development/architecture.rstis up-to-date