Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Fixed transpose #165

Closed
wants to merge 11 commits into from
Closed

[WIP] Fixed transpose #165

wants to merge 11 commits into from

Conversation

williamma12
Copy link
Collaborator

@williamma12 williamma12 commented Oct 13, 2018 •
edited
Loading

What do these changes do?

Takes the transpose of each partition when we do transpose

Related issue number

Resolves #164

  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • passes black --check modin/

@williamma12 williamma12 changed the title Fixed transpose [WIP] Fixed transpose Oct 13, 2018
@williamma12 williamma12 changed the title [WIP] Fixed transpose Fixed transpose Oct 16, 2018
devin-petersohn
devin-petersohn reviewed Oct 16, 2018
View reviewed changes
Copy link
Collaborator

@devin-petersohn devin-petersohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments

modin/data_management/data_manager.py Outdated Show resolved Hide resolved
modin/data_management/data_manager.py Outdated Show resolved Hide resolved
@AmplabJenkins
Copy link

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin/264/
Test FAILed.

@AmplabJenkins
Copy link

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin/267/
Test FAILed.

@AmplabJenkins
Copy link

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin/275/
Test FAILed.

@AmplabJenkins
Copy link

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin/282/
Test FAILed.

@williamma12 williamma12 mentioned this pull request Oct 16, 2018
Merged
2 tasks
@williamma12 williamma12 changed the title Fixed transpose [WIP] Fixed transpose Oct 16, 2018
@williamma12 williamma12 added the Blocked ❌ A pull request that is blocked label Dec 5, 2018
@williamma12
Copy link
Collaborator Author

Blocked on #93

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devin-petersohn devin-petersohn devin-petersohn left review comments

Assignees
No one assigned
Labels
Blocked ❌ A pull request that is blocked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some operations do not work after we take the transpose
4 participants
@williamma12 @AmplabJenkins @devin-petersohn @simon-mo