Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding advanced usage docs #250

Merged
merged 4 commits into from
Nov 11, 2018
Merged

Adding advanced usage docs #250

merged 4 commits into from
Nov 11, 2018

Conversation

devin-petersohn
Copy link
Collaborator

@devin-petersohn devin-petersohn commented Nov 9, 2018 •
edited
Loading

What do these changes do?

Related issue number

  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • passes black --check modin/

@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-Performance-Testing/44/
Test PASSed.

@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-PRB/55/
Test PASSed.

@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-Performance-Testing/47/
Test PASSed.

@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-PRB/58/
Test PASSed.

osalpekar
osalpekar approved these changes Nov 10, 2018
View reviewed changes
Copy link
Collaborator

@osalpekar osalpekar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment on wording for one of the sentences, otherwise looks good!

docs/using_modin.rst
num_bytes = 2**40 # Make sure you have disk space to do this!
ray.init(plasma_directory="/tmp", object_store_memory=num_bytes)
import modin.pandas as pd

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion for next line:
Setting plasma_directory="/tmp" uses your disk for storing the DataFrame and setting object_store_memory sets the maximum size of the plasma store.

williamma12
williamma12 requested changes Nov 10, 2018
View reviewed changes
Copy link
Collaborator

@williamma12 williamma12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left some comments to make everything flow better

docs/using_modin.rst Outdated Show resolved Hide resolved
docs/using_modin.rst Show resolved Hide resolved
docs/using_modin.rst Outdated Show resolved Hide resolved
@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-Performance-PRB/2/
Test PASSed.

@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-PRB/65/
Test PASSed.

@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-Performance-PRB/3/
Test PASSed.

@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-PRB/66/
Test PASSed.

@devin-petersohn devin-petersohn merged commit 0041447 into modin-project:master Nov 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williamma12 williamma12 williamma12 requested changes

@osalpekar osalpekar osalpekar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devin-petersohn @AmplabJenkins @williamma12 @osalpekar