Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pandas version to 0.24.2 #509

Conversation

devin-petersohn
Copy link
Collaborator

What do these changes do?

Update the pandas version to 0.24.2

Related issue number

N/A

  • passes flake8 modin
  • passes black --check modin
  • tests added and passing

@AmplabJenkins
Copy link

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-PRB/632/
Test FAILed.

@codecov
Copy link

codecov bot commented Mar 22, 2019

Codecov Report

Merging #509 into master will decrease coverage by 0.01%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #509      +/-   ##
==========================================
- Coverage   90.24%   90.22%   -0.02%     
==========================================
  Files          34       34              
  Lines        4849     4851       +2     
==========================================
+ Hits         4376     4377       +1     
- Misses        473      474       +1
Impacted Files Coverage Δ
modin/pandas/__init__.py 84.78% <100%> (ø) ⬆️
modin/backends/pandas/query_compiler.py 90.44% <75%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d992d97...8153ed7. Read the comment docs.

@AmplabJenkins
Copy link

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-PRB/642/
Test FAILed.

@AmplabJenkins
Copy link

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-PRB/647/
Test FAILed.

Copy link
Collaborator

@williamma12 williamma12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! The code coverage issue can probably be ignored once we get the merge conflict resolved

@devin-petersohn devin-petersohn merged commit 66d049d into modin-project:master Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants