New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT-#6382: Execute bitwise NOT (~) operations on HDK #6383
Conversation
67cfb09
to
c5be01d
Compare
@AndreyPavlenko should it work with new hdk release 0.9.0? |
c5be01d
to
aeedbf0
Compare
Yes it should. I've rebased on master - the HDK tests passed, but there are a lot of failures in other tests, for some reason. |
It's due the new pandas 2.1.2 release. Fixes for it here: #6685 |
@AndreyPavlenko #6685 is merged. Could yo rebase on master branch? |
Signed-off-by: Andrey Pavlenko <andrey.a.pavlenko@gmail.com>
aeedbf0
to
2985e2a
Compare
@@ -485,7 +485,7 @@ def invert(self) -> "OpExpr": | |||
OpExpr | |||
The resulting bitwise inverse expression. | |||
""" | |||
return OpExpr("~", [self], self._dtype) | |||
return OpExpr("BIT_NOT", [self], self._dtype) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we test this operation on HDK?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, there is a test - https://github.com/modin-project/modin/blob/master/modin/experimental/core/execution/native/implementations/hdk_on_native/test/test_dataframe.py#L2014 . Currently it's executed on arrow due to https://github.com/modin-project/modin/blob/master/modin/experimental/core/execution/native/implementations/hdk_on_native/expr.py#L1007, but this PR enables the HDK execution.
What do these changes do?
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
git commit -s
docs/development/architecture.rst
is up-to-date