Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT-#6382: Execute bitwise NOT (~) operations on HDK #6383

Merged
merged 1 commit into from Jan 23, 2024

Conversation

AndreyPavlenko
Copy link
Collaborator

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Execute bitwise NOT (~) operations on HDK #6382
  • [] tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@anmyachev
Copy link
Collaborator

@AndreyPavlenko should it work with new hdk release 0.9.0?

@AndreyPavlenko
Copy link
Collaborator Author

@AndreyPavlenko should it work with new hdk release 0.9.0?

Yes it should. I've rebased on master - the HDK tests passed, but there are a lot of failures in other tests, for some reason.

@anmyachev
Copy link
Collaborator

@AndreyPavlenko should it work with new hdk release 0.9.0?

Yes it should. I've rebased on master - the HDK tests passed, but there are a lot of failures in other tests, for some reason.

It's due the new pandas 2.1.2 release. Fixes for it here: #6685

@anmyachev
Copy link
Collaborator

@AndreyPavlenko #6685 is merged. Could yo rebase on master branch?

Signed-off-by: Andrey Pavlenko <andrey.a.pavlenko@gmail.com>
@@ -485,7 +485,7 @@ def invert(self) -> "OpExpr":
OpExpr
The resulting bitwise inverse expression.
"""
return OpExpr("~", [self], self._dtype)
return OpExpr("BIT_NOT", [self], self._dtype)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we test this operation on HDK?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YarShev YarShev merged commit 5d66fe8 into modin-project:master Jan 23, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Execute bitwise NOT (~) operations on HDK
4 participants