Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT-#6382: Execute bitwise NOT (~) operations on HDK #6383

Merged
merged 1 commit into from
Jan 23, 2024
Merged

FEAT-#6382: Execute bitwise NOT (~) operations on HDK #6383

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions modin/experimental/core/execution/native/implementations/hdk_on_native/expr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,7 +485,7 @@ def invert(self) -> "OpExpr":
OpExpr
The resulting bitwise inverse expression.
"""
return OpExpr("~", [self], self._dtype)
return OpExpr("BIT_NOT", [self], self._dtype)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we test this operation on HDK?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, there is a test - https://github.com/modin-project/modin/blob/master/modin/experimental/core/execution/native/implementations/hdk_on_native/test/test_dataframe.py#L2014 . Currently it's executed on arrow due to https://github.com/modin-project/modin/blob/master/modin/experimental/core/execution/native/implementations/hdk_on_native/expr.py#L1007, but this PR enables the HDK execution.


def _cmp_op(self, other, op_name):
"""
Expand Down Expand Up @@ -983,7 +983,7 @@ class OpExpr(BaseExpr):
"POWER": lambda self: self._fold_arithm("__pow__"),
"/": lambda self: self._fold_arithm("__truediv__"),
"//": lambda self: self._fold_arithm("__floordiv__"),
"~": lambda self: self._fold_invert(),
"BIT_NOT": lambda self: self._fold_invert(),
"CAST": lambda self: self._fold_literal("cast", self._dtype),
"IS NULL": lambda self: self._fold_literal("is_null"),
"IS NOT NULL": lambda self: self._fold_literal("is_not_null"),
Expand All @@ -996,15 +996,15 @@ class OpExpr(BaseExpr):
"POWER": lambda self, table: self._pc("power", table),
"/": lambda self, table: self._pc("divide", table),
"//": lambda self, table: self._pc("divide", table),
"~": lambda self, table: self._invert(table),
"BIT_NOT": lambda self, table: self._invert(table),
"CAST": lambda self, table: self._col(table).cast(to_arrow_type(self._dtype)),
"IS NULL": lambda self, table: self._col(table).is_null(nan_is_null=True),
"IS NOT NULL": lambda self, table: pc.invert(
self._col(table).is_null(nan_is_null=True)
),
}

_UNSUPPORTED_HDK_OPS = {"~"}
_UNSUPPORTED_HDK_OPS = {}

def __init__(self, op, operands, dtype):
self.op = op
Expand Down