Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX-#6830: Pass AWS related env vars to mpiexec #6867

Merged
merged 8 commits into from Jan 19, 2024
Merged

FIX-#6830: Pass AWS related env vars to mpiexec #6867

merged 8 commits into from Jan 19, 2024

Conversation

anmyachev
Copy link
Collaborator

@anmyachev anmyachev commented Jan 19, 2024 •
edited by YarShev

CI on master is failing for MPI due to missing env vars related to AWS.

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves #?
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@anmyachev
FIX-modin-project#6830: hotfix for CI
a3d446a 
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev
revert me
2c30078 
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev
fixes
7a501f2 
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev
revert me
9c220c7 
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev
add missed dependency 'gcsfs'
49dcc44 
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev anmyachev added the P0 Highest priority tasks requiring immediate fix label Jan 19, 2024
@anmyachev
remove gcsfs for now
ca92b93 
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev anmyachev mentioned this pull request Jan 19, 2024
Closed
@anmyachev
Revert "revert me"
f8466c8 
This reverts commit 2c30078.
@anmyachev
Revert "revert me"
5bdf430 
This reverts commit 9c220c7.
@anmyachev anmyachev marked this pull request as ready for review January 19, 2024 12:56
@YarShev YarShev changed the title FIX-#6830: hotfix for CI FIX-#6830: Pass AWS related env vars to mpiexec Jan 19, 2024
@YarShev YarShev merged commit 097ea52 into modin-project:master Jan 19, 2024
33 checks passed
@anmyachev anmyachev deleted the issue6830_2 branch January 19, 2024 13:49
anmyachev added a commit that referenced this pull request Jan 19, 2024
@anmyachev
FIX-#6830: Pass AWS related env vars to mpiexec (#6867)
9451c24 
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YarShev YarShev YarShev approved these changes

@devin-petersohn devin-petersohn Awaiting requested review from devin-petersohn devin-petersohn is a code owner

@mvashishtha mvashishtha Awaiting requested review from mvashishtha mvashishtha is a code owner

@RehanSD RehanSD Awaiting requested review from RehanSD RehanSD is a code owner

@vnlitvinov vnlitvinov Awaiting requested review from vnlitvinov vnlitvinov is a code owner

@dchigarev dchigarev Awaiting requested review from dchigarev dchigarev is a code owner

Assignees
No one assigned
Labels
P0 Highest priority tasks requiring immediate fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anmyachev @YarShev