Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missed gcsfs dependency in CI #6868

Closed
anmyachev opened this issue Jan 19, 2024 · 0 comments · Fixed by #6882
Closed

Missed gcsfs dependency in CI #6868

anmyachev opened this issue Jan 19, 2024 · 0 comments · Fixed by #6882
Labels
P1 Important tasks that we should complete soon Testing 📈 Issues related to testing

Comments

@anmyachev
Copy link
Collaborator

anmyachev commented Jan 19, 2024 •
edited

Tests test_read_multiple_csv_cloud_store and test_read_csv_google_cloud_storage are not actually tested, but simply fail with the same error (lack of the required module: gcsfs) when compared with pandas.

The main reason: #6016

Found in #6867
@anmyachev anmyachev added Testing 📈 Issues related to testing P1 Important tasks that we should complete soon labels Jan 19, 2024
anmyachev added a commit to anmyachev/modin that referenced this issue Jan 25, 2024
@anmyachev
TEST-modin-project#6868: Remove tests for 'gs' remote protocol since …
87a81b3 
…we rely on 'fsspec'

Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev anmyachev mentioned this issue Jan 25, 2024
Merged
7 tasks
YarShev pushed a commit that referenced this issue Jan 26, 2024
@anmyachev
TEST-#6868: Remove tests for 'gs' remote protocol since we rely on 'f…
808b0bf 
…sspec' (#6882)

Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P1 Important tasks that we should complete soon Testing 📈 Issues related to testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

TEST-#6868: Remove tests for 'gs' remote protocol since Modin rely on 'fsspec' anmyachev/modin
1 participant
@anmyachev