Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST-#6868: Remove tests for 'gs' remote protocol since Modin rely on 'fsspec' #6882

Merged
merged 1 commit into from Jan 26, 2024

Conversation

anmyachev
Copy link
Collaborator

@anmyachev anmyachev commented Jan 25, 2024

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Missed gcsfs dependency in CI #6868
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

…we rely on 'fsspec'

Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev anmyachev marked this pull request as ready for review January 25, 2024 16:49
Copy link
Collaborator

@YarShev YarShev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do I understand correctly that we have the same code path both for s3 and gs and we rely on fsspec with respect to it has proper testing for both protocols?

@anmyachev
Copy link
Collaborator Author

Do I understand correctly that we have the same code path both for s3 and gs and we rely on fsspec with respect to it has proper testing for both protocols?

Exactly

@YarShev YarShev merged commit 808b0bf into modin-project:master Jan 26, 2024
37 checks passed
@anmyachev anmyachev deleted the issue6868 branch January 26, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missed gcsfs dependency in CI
3 participants