Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX-#6899: Avoid sending lazy categorical proxies to workers #6900

Merged
merged 3 commits into from Jan 31, 2024
Merged

FIX-#6899: Avoid sending lazy categorical proxies to workers #6900

merged 3 commits into from Jan 31, 2024

Conversation

dchigarev
Copy link
Collaborator

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Groupby tests hang on dask #6899
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@dchigarev
FIX-modin-project#6899: Avoid sending lazy categorical proxies to wor…
6b7fc09 
…kers

Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
@YarShev YarShev mentioned this pull request Jan 31, 2024
Merged
7 tasks
@YarShev
Copy link
Collaborator

YarShev commented Jan 31, 2024

Is this PR ready for review?

dchigarev
dchigarev commented Jan 31, 2024
View reviewed changes
modin/pandas/test/test_groupby.py
@@ -3164,14 +3164,6 @@ def test_groupby_agg_provided_callable_warning():
pandas_groupby.agg(func)


def _apply_transform(df):
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dask hangs if I try to submit a function from the global testing scope, so rewritten this function as a lambda

@dchigarev dchigarev marked this pull request as ready for review January 31, 2024 15:40
@dchigarev
Copy link
Collaborator Author

Is this PR ready for review?

now it's ready

@YarShev YarShev merged commit 7c4a665 into modin-project:master Jan 31, 2024
36 checks passed
@dchigarev dchigarev mentioned this pull request Feb 1, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YarShev YarShev YarShev approved these changes

@devin-petersohn devin-petersohn Awaiting requested review from devin-petersohn devin-petersohn is a code owner

@mvashishtha mvashishtha Awaiting requested review from mvashishtha mvashishtha is a code owner

@RehanSD RehanSD Awaiting requested review from RehanSD RehanSD is a code owner

@vnlitvinov vnlitvinov Awaiting requested review from vnlitvinov vnlitvinov is a code owner

@anmyachev anmyachev Awaiting requested review from anmyachev anmyachev is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Groupby tests hang on dask
2 participants
@dchigarev @YarShev