Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX-#6897: Revert unidist specific workaround for groupby #6902

Merged
merged 1 commit into from Feb 1, 2024
Merged

FIX-#6897: Revert unidist specific workaround for groupby #6902

merged 1 commit into from Feb 1, 2024

Conversation

dchigarev
Copy link
Collaborator

@dchigarev dchigarev commented Feb 1, 2024 •
edited

What do these changes do?

The actual issue was fixed by #6900, so we don't need this workaround anymore

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Groupby tests on MPI are failing #6897
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@dchigarev
FIX-modin-project#6897: Revert unidist specific fix for groupby
4f06079 
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
@dchigarev dchigarev mentioned this pull request Feb 1, 2024
Merged
7 tasks
@dchigarev dchigarev changed the title FIX-#6897: Revert unidist specific fix for groupby FIX-#6897: Revert unidist specific workaround for groupby Feb 1, 2024
@dchigarev dchigarev marked this pull request as ready for review February 1, 2024 11:52
@YarShev YarShev merged commit 3e42b8b into modin-project:master Feb 1, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YarShev YarShev YarShev approved these changes

@devin-petersohn devin-petersohn Awaiting requested review from devin-petersohn devin-petersohn is a code owner

@mvashishtha mvashishtha Awaiting requested review from mvashishtha mvashishtha is a code owner

@RehanSD RehanSD Awaiting requested review from RehanSD RehanSD is a code owner

@vnlitvinov vnlitvinov Awaiting requested review from vnlitvinov vnlitvinov is a code owner

@anmyachev anmyachev Awaiting requested review from anmyachev anmyachev is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Groupby tests on MPI are failing
2 participants
@dchigarev @YarShev