Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT-#6914: Add a config for setting a number of threads per Dask worker #6915

Merged
merged 3 commits into from Feb 6, 2024
Merged

FEAT-#6914: Add a config for setting a number of threads per Dask worker #6915

merged 3 commits into from Feb 6, 2024

Conversation

YarShev
Copy link
Collaborator

@YarShev YarShev commented Feb 6, 2024

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Number of threads per Dask worker #6914
  • tests passing
  • module layout described at docs/development/architecture.rst is up-to-date

@YarShev
FEAT-modin-project#6914: Add a config for setting a number of threads…
ac6155e 
… per Dask worker

Signed-off-by: Igoshev, Iaroslav <iaroslav.igoshev@intel.com>
@YarShev
Fix import
c9499b4 
Signed-off-by: Igoshev, Iaroslav <iaroslav.igoshev@intel.com>
dchigarev
dchigarev previously approved these changes Feb 6, 2024
View reviewed changes
@YarShev
1 to None
c7bfd4e 
Signed-off-by: Igoshev, Iaroslav <iaroslav.igoshev@intel.com>
anmyachev
anmyachev approved these changes Feb 6, 2024
View reviewed changes
Copy link
Collaborator

@anmyachev anmyachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@anmyachev anmyachev merged commit 2cdb534 into modin-project:master Feb 6, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anmyachev anmyachev anmyachev approved these changes

@dchigarev dchigarev dchigarev left review comments

@devin-petersohn devin-petersohn Awaiting requested review from devin-petersohn devin-petersohn is a code owner

@mvashishtha mvashishtha Awaiting requested review from mvashishtha mvashishtha is a code owner

@RehanSD RehanSD Awaiting requested review from RehanSD RehanSD is a code owner

@vnlitvinov vnlitvinov Awaiting requested review from vnlitvinov vnlitvinov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Number of threads per Dask worker
3 participants
@YarShev @anmyachev @dchigarev