Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT-#6914: Add a config for setting a number of threads per Dask worker #6915

Merged
merged 3 commits into from
Feb 6, 2024
Merged

FEAT-#6914: Add a config for setting a number of threads per Dask worker #6915

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ac6155e
FEAT-#6914: Add a config for setting a number of threads per Dask worker
YarShev Feb 6, 2024
c9499b4
Fix import
YarShev Feb 6, 2024
c7bfd4e
1 to None
YarShev Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions modin/config/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
CIAWSAccessKeyID,
CIAWSSecretAccessKey,
CpuCount,
DaskThreadsPerWorker,
DoUseCalcite,
Engine,
EnvironmentVariable,
Expand Down Expand Up @@ -73,6 +74,8 @@
"RayRedisPassword",
"TestRayClient",
"LazyExecution",
# Dask specific
"DaskThreadsPerWorker",
# Partitioning
"NPartitions",
"MinPartitionSize",
Expand Down
7 changes: 7 additions & 0 deletions modin/config/envvars.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -830,6 +830,13 @@ class LazyExecution(EnvironmentVariable, type=bool):
default = False


class DaskThreadsPerWorker(EnvironmentVariable, type=int):
"""Number of threads per Dask worker."""

varname = "MODIN_DASK_THREADS_PER_WORKER"
default = None


def _check_vars() -> None:
"""
Check validity of environment variables.
Expand Down
8 changes: 7 additions & 1 deletion modin/core/execution/dask/common/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
CIAWSAccessKeyID,
CIAWSSecretAccessKey,
CpuCount,
DaskThreadsPerWorker,
GithubCI,
Memory,
NPartitions,
Expand Down Expand Up @@ -54,12 +55,17 @@ def _disable_warnings():
""",
)
num_cpus = CpuCount.get()
threads_per_worker = DaskThreadsPerWorker.get()
memory_limit = Memory.get()
worker_memory_limit = memory_limit // num_cpus if memory_limit else "auto"

# when the client is initialized, environment variables are inherited
with set_env(PYTHONWARNINGS="ignore::FutureWarning"):
client = Client(n_workers=num_cpus, memory_limit=worker_memory_limit)
client = Client(
n_workers=num_cpus,
threads_per_worker=threads_per_worker,
YarShev marked this conversation as resolved.
Show resolved Hide resolved
memory_limit=worker_memory_limit,
)

if GithubCI.get():
# set these keys to run tests that write to the mock s3 service. this seems
Expand Down