Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX-#6944: Apply 'isort' formatting for scripts from tutorials #6945

Merged
merged 3 commits into from Feb 19, 2024
Merged

FIX-#6944: Apply 'isort' formatting for scripts from tutorials #6945

merged 3 commits into from Feb 19, 2024

Conversation

dchigarev
Copy link
Collaborator

@dchigarev dchigarev commented Feb 19, 2024 •
edited

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves isort check fails on master #6944
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@dchigarev
REFACTOR-modin-project#6944: Apply 'isort' formatting for scripts fro…
cb87263 
…m tutorials

Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
@dchigarev
add 'isort' check to 'ci-required'
c55e242 
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
dchigarev
dchigarev commented Feb 19, 2024
View reviewed changes
.github/workflows/ci-required.yml
@@ -105,3 +105,15 @@ jobs:
- run: python scripts/doc_checker.py modin/experimental/core/execution/native/implementations/hdk_on_native/interchange/dataframe_protocol
- run: python scripts/doc_checker.py modin/experimental/batch/pipeline.py
- run: python scripts/doc_checker.py modin/logging

lint-black-isort:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

previously, the isort check was only triggered if the modin's code was modified, that's why #6872 was showing green CI in PR but started failing after the merge

@dchigarev
add a newline at the end of file
2f49bf7 
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
@anmyachev
Copy link
Collaborator

@dchigarev it's better to rename it to "FIX-" so we don't forget to add the PR to the patch release.

@dchigarev dchigarev changed the title REFACTOR-#6944: Apply 'isort' formatting for scripts from tutorials FIX-#6944: Apply 'isort' formatting for scripts from tutorials Feb 19, 2024
@anmyachev anmyachev merged commit 5ec075d into modin-project:master Feb 19, 2024
12 of 13 checks passed
@dchigarev dchigarev mentioned this pull request Feb 19, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anmyachev anmyachev anmyachev approved these changes

@devin-petersohn devin-petersohn Awaiting requested review from devin-petersohn devin-petersohn is a code owner

@mvashishtha mvashishtha Awaiting requested review from mvashishtha mvashishtha is a code owner

@RehanSD RehanSD Awaiting requested review from RehanSD RehanSD is a code owner

@YarShev YarShev Awaiting requested review from YarShev YarShev is a code owner

@vnlitvinov vnlitvinov Awaiting requested review from vnlitvinov vnlitvinov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

isort check fails on master
2 participants
@dchigarev @anmyachev