Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX-#6946: Remove 'needs: [lint-black-isort, ...]' #6947

Merged
merged 1 commit into from Feb 19, 2024

Conversation

dchigarev
Copy link
Collaborator

@dchigarev dchigarev commented Feb 19, 2024

What do these changes do?

The lint-black-isort was moved to another file (#6945), so referencing it is no longer valid

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Remove needs: [lint-black-isort, ...] #6946
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
needs: [lint-flake8, lint-black-isort]
needs: [lint-flake8]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jobs from ci-required.yml are not technically required to run jobs from ci.yml, so this PR actually changes the ci's flow, allowing for the jobs to be run even if lint-black-isort haven't passed successful (hope it's not a problem, or anyone have a solution for this?)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could only move isort to another ci flow, and leave black here. The only reason to leave black is it can find syntax errors and return an error sooner. However I don't mind trying the current solution.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flake8 can also find syntax errors, so let's leave it as it is

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@dchigarev dchigarev marked this pull request as ready for review February 19, 2024 16:57
@anmyachev anmyachev merged commit b875991 into modin-project:master Feb 19, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove needs: [lint-black-isort, ...]
2 participants