Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT-#7001: Do not force materialization in MetaList.__getitem__() #7006
FEAT-#7001: Do not force materialization in MetaList.__getitem__() #7006
Changes from 1 commit
ae05a5a
ea99f5b
c82380a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am kind of confused why this method is named map. Can you elaborate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main idea is to apply some calculation to a single materialized object and get one or multiple values. List with lengths is mapped to multiple lengths with MetaListMapper. Length is mapped to a different length with SlicedLenMapper.
If it's confusing, I let's rename it fo, for example, transfrom.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renamed to MaterializationHook.
Check warning on line 100 in modin/core/execution/ray/common/engine_wrapper.py
Codecov / codecov/patch
modin/core/execution/ray/common/engine_wrapper.py#L100
Check warning on line 140 in modin/core/execution/ray/common/engine_wrapper.py
Codecov / codecov/patch
modin/core/execution/ray/common/engine_wrapper.py#L139-L140
Check warning on line 214 in modin/core/execution/ray/common/engine_wrapper.py
Codecov / codecov/patch
modin/core/execution/ray/common/engine_wrapper.py#L214
Check warning on line 219 in modin/core/execution/ray/common/engine_wrapper.py
Codecov / codecov/patch
modin/core/execution/ray/common/engine_wrapper.py#L219
Check warning on line 215 in modin/core/execution/ray/implementations/pandas_on_ray/partitioning/partition.py
Codecov / codecov/patch
modin/core/execution/ray/implementations/pandas_on_ray/partitioning/partition.py#L215
Check warning on line 445 in modin/core/execution/ray/implementations/pandas_on_ray/partitioning/partition.py
Codecov / codecov/patch
modin/core/execution/ray/implementations/pandas_on_ray/partitioning/partition.py#L443-L445
Check warning on line 450 in modin/core/execution/ray/implementations/pandas_on_ray/partitioning/partition.py
Codecov / codecov/patch
modin/core/execution/ray/implementations/pandas_on_ray/partitioning/partition.py#L450
Check warning on line 466 in modin/core/execution/ray/implementations/pandas_on_ray/partitioning/partition.py
Codecov / codecov/patch
modin/core/execution/ray/implementations/pandas_on_ray/partitioning/partition.py#L464-L466