Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PERF-#5296: Partition parquet file if it has too few row groups #7016

Merged
merged 7 commits into from
Mar 8, 2024

Conversation

dchigarev
Copy link
Collaborator

@dchigarev dchigarev commented Mar 6, 2024

What do these changes do?

The PR corrects unbalanced partitioning after .read_parquet(). It basically applies the logic of qc.repartition() but at the partitions level (for some reason, this implementation works much faster):

image

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Modin doesn't partition DataFrames read from a parquet file if the file itself isn't partitioned #5296
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

… groups

Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
@dchigarev dchigarev marked this pull request as ready for review March 8, 2024 11:55
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
@anmyachev
Copy link
Collaborator

@YarShev any other comments?

@YarShev YarShev merged commit b1501d8 into modin-project:master Mar 8, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modin doesn't partition DataFrames read from a parquet file if the file itself isn't partitioned
3 participants