Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More efficiently manage metadata internally #721

Merged
merged 49 commits into from
Aug 28, 2019
Merged

More efficiently manage metadata internally #721

merged 49 commits into from
Aug 28, 2019

Conversation

devin-petersohn
Copy link
Collaborator

@devin-petersohn devin-petersohn commented Jul 5, 2019 •
edited
Loading

What do these changes do?

Related issue number

  • passes flake8 modin
  • passes black --check modin
  • tests added and passing

@devin-petersohn
Improve performance of dtypes computation by collecting at data ingest
edb890b 
Add metadata class and handle metadata more efficiently

Start WIP PR

Update remote

Make print work

Update remote

Fix bug
@devin-petersohn
Add Functions class
d92357f
@devin-petersohn devin-petersohn mentioned this pull request Aug 12, 2019
Closed
@codecov
Copy link

codecov bot commented Aug 13, 2019 •
edited
Loading

Codecov Report

Merging #721 into master will decrease coverage by 2.51%.
The diff coverage is 90.08%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #721      +/-   ##
==========================================
- Coverage   90.78%   88.27%   -2.52%     
==========================================
  Files          37       44       +7     
  Lines        6199     5661     -538     
==========================================
- Hits         5628     4997     -631     
- Misses        571      664      +93
Impacted Files Coverage Δ
modin/pandas/__init__.py 82.69% <ø> (-1.93%) ⬇️
modin/data_management/utils.py 65.11% <ø> (-20%) ⬇️
.../engines/ray/pandas_on_ray/frame/axis_partition.py 100% <ø> (ø) ⬆️
modin/backends/pandas/query_compiler.py 84.19% <ø> (-8.21%) ⬇️
...engines/python/pandas_on_python/frame/partition.py 34.42% <0%> (-58.91%) ⬇️
modin/experimental/engines/pandas_on_ray/io_exp.py 43.24% <0%> (+1.13%) ⬆️
modin/pandas/series.py 93.27% <100%> (ø) ⬆️
modin/pandas/indexing.py 82.96% <100%> (+1.84%) ⬆️
...odin/engines/python/pandas_on_python/frame/data.py 100% <100%> (ø)
modin/engines/base/frame/partition.py 100% <100%> (ø)
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c26a9b1...28f6f51. Read the comment docs.

williamma12
williamma12 reviewed Aug 27, 2019
View reviewed changes
Copy link
Collaborator

@williamma12 williamma12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also update the docs to reflect the new changes made

modin/backends/pandas/query_compiler.py Outdated Show resolved Hide resolved
modin/backends/pandas/query_compiler.py Show resolved Hide resolved
modin/backends/pandas/query_compiler.py Show resolved Hide resolved
modin/backends/pandas/query_compiler.py Show resolved Hide resolved
modin/backends/pandas/query_compiler.py Outdated Show resolved Hide resolved
modin/backends/pandas/query_compiler.py Show resolved Hide resolved
modin/engines/base/frame/data.py Show resolved Hide resolved
modin/engines/ray/generic/io.py Show resolved Hide resolved
modin/engines/ray/pandas_on_ray/frame/partition_manager.py Outdated Show resolved Hide resolved
modin/pandas/test/test_dataframe.py Outdated Show resolved Hide resolved
williamma12
williamma12 reviewed Aug 28, 2019
View reviewed changes
Copy link
Collaborator

@williamma12 williamma12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor things left!

modin/backends/base/query_compiler.py Outdated Show resolved Hide resolved
modin/engines/base/frame/partition.py Outdated Show resolved Hide resolved
modin/engines/base/frame/data.py Outdated Show resolved Hide resolved
devin-petersohn and others added 3 commits August 27, 2019 22:17
@devin-petersohn @williamma12
Update modin/engines/base/frame/data.py
73ef11c 
Co-Authored-By: William Ma <12377941+williamma12@users.noreply.github.com>
@devin-petersohn
Address comments
124a1d8
@devin-petersohn
Address comments
28f6f51
@devin-petersohn devin-petersohn changed the title [WIP] More efficiently manage metadata internally More efficiently manage metadata internally Aug 28, 2019
williamma12
williamma12 approved these changes Aug 28, 2019
View reviewed changes
Copy link
Collaborator

@williamma12 williamma12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @devin-petersohn!

@williamma12 williamma12 merged commit 54b28cd into modin-project:master Aug 28, 2019
This was referenced Aug 29, 2019
Closed
Closed
Closed
Closed
@devin-petersohn devin-petersohn mentioned this pull request Jan 22, 2020
Closed
@mvashishtha mvashishtha mentioned this pull request Jul 25, 2022
Merged
8 tasks
This was referenced Feb 28, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williamma12 williamma12 williamma12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devin-petersohn @williamma12