Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not apply proxy settings automatically #88

Closed
aalmiray opened this issue Feb 4, 2021 · 3 comments
Closed

Do not apply proxy settings automatically #88

aalmiray opened this issue Feb 4, 2021 · 3 comments
Assignees
@aalmiray
Labels
bug Something isn't working released Issue has been released
Milestone
1.0.0.Beta1

Comments

@aalmiray
Copy link
Contributor

aalmiray commented Feb 4, 2021

Proxy settings should be applied if an only if a proxy is needed. Current code (1.0.0.Alpha1) fails when no proxy is required yet one is applied to the HttpClient.
@aalmiray aalmiray added the bug Something isn't working label Feb 4, 2021
@aalmiray aalmiray self-assigned this Feb 4, 2021
aalmiray added a commit to aalmiray/layrry that referenced this issue Feb 4, 2021
@aalmiray
Issue moditect#88. Rework and document proxy configuration
7277ec3
@aalmiray aalmiray mentioned this issue Feb 4, 2021
Merged
aalmiray added a commit to aalmiray/layrry that referenced this issue Feb 8, 2021
@aalmiray
Issue moditect#88. Load system properties as defaults
15bb4dc
aalmiray added a commit to aalmiray/layrry that referenced this issue Feb 8, 2021
@aalmiray
Issue moditect#88. Clarify using proxy properties
123c0d7
gunnarmorling pushed a commit that referenced this issue Feb 8, 2021
@aalmiray @gunnarmorling
Issue #88. Rework and document proxy configuration
ddac9d0
gunnarmorling pushed a commit that referenced this issue Feb 8, 2021
@aalmiray @gunnarmorling
Issue #88. Load system properties as defaults
a6ac571
gunnarmorling pushed a commit that referenced this issue Feb 8, 2021
@aalmiray @gunnarmorling
Issue #88. Clarify using proxy properties
74410ed
@gunnarmorling gunnarmorling added this to the 1.0.0.Beta1 milestone Feb 8, 2021
@gunnarmorling
Copy link
Member

@aalmiray, added this and #87 to a new milestone, 1.0.0.Beta1. I think it makes sense to start tracking items like that now that the first release went out.

@gunnarmorling
Copy link
Member

Also, as a good measure, let's try and have an issue that can be referenced for each (substantial) commit. No need for that for typo fixes etc. I put the PR from @joschi into that milestone too, as there was no issue for it. Let's usually avoid that though and only track issues in milestones.

@github-actions github-actions bot added the released Issue has been released label Oct 31, 2022
@github-actions
Copy link
Contributor

Released in v1.0.0.Alpha2 -> https://github.com/moditect/layrry/releases/tag/v1.0.0.Alpha2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aalmiray aalmiray

Labels
bug Something isn't working released Issue has been released
Projects
None yet
Milestone
1.0.0.Beta1
Development

No branches or pull requests
2 participants
@aalmiray @gunnarmorling