Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Support multiple launchers (entry points) #104

Open
donmendelson opened this issue Sep 3, 2019 · 1 comment
Open

Feature request: Support multiple launchers (entry points) #104

donmendelson opened this issue Sep 3, 2019 · 1 comment

Comments

@donmendelson
Copy link

My project is an XML diff/merge utility so I need to have entry points for two methods. Currently, the plugin only supports a single launcher, but I found that jlink does support multiple launchers from the command line. For each launcher, jlink generates a Windows .bat file and a sh script.

To support this functionality, the plugin configuration needs to change to something like:

<launchers>
	<launcher>
		<name>xmldiff</name>
		<module>diff.merge/io.fixprotocol.xml.XmlDiff</module>
	</launcher>
	<launcher>
		<name>xmlmerge</name>
		<module>diff.merge/io.fixprotocol.xml.XmlMerge</module>
	</launcher>
</launchers>

Also, the configuration isn't obvious, even for a single launcher. The name attribute is used as the name of a script to generate. The module attribute gets passed to jlink as a command. It can be of the form module/main-class. Either the attribute could change to command or it could be broken into module + main attributes.

@gunnarmorling
Copy link
Member

Hi, so if multiple launchers are supported by jlink itself, then +1 by all means for supporting it in ModiTect, too. Would you be interested in sending in a PR, @donmendelson?

donmendelson added a commit to donmendelson/moditect that referenced this issue Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants