Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build error on JDK8 due to the use of a field only available since Java 9 #55

Closed
beikov opened this issue Apr 29, 2018 · 3 comments
Closed

Build error on JDK8 due to the use of a field only available since Java 9 #55

beikov opened this issue Apr 29, 2018 · 3 comments
Milestone
1.0.0.Beta2

Comments

@beikov
Copy link
Contributor

beikov commented Apr 29, 2018

The use of the MULTI_RELEASE manifest attribute name leads to an error when executing a build on JDK 8. I must have missed that when testing #53
@beikov
Copy link
Contributor Author

beikov commented Apr 29, 2018 •
edited

Also, I just realized, that having JARs with an existing MANIFEST.MF leads to an exception when specifying the jvm version element because the ZipFileSystem reports that META-INF/MANIFEST.MF already exists.

Unfortunately, even though the module-info.class file is now in META-INF, Jandex will still fail to index the JAR, so this feature will not help with that problem.

beikov added a commit to beikov/moditect that referenced this issue Apr 29, 2018
@beikov
[moditect#55] Replace use of MULTI_RELEASE manifest attribute name fi…
190dcd9 
…eld which is only available in Java 9 and fix problems with JARs when manifest already exists
beikov added a commit to beikov/moditect that referenced this issue Apr 29, 2018
@beikov
[moditect#55] Replace use of MULTI_RELEASE manifest attribute name fi…
dd5bfbf 
…eld which is only available in Java 9 and fix problems with JARs when manifest already exists
@beikov beikov mentioned this issue Apr 29, 2018
Merged
gunnarmorling pushed a commit that referenced this issue Oct 3, 2018
@beikov @gunnarmorling
[#55] Replace use of MULTI_RELEASE manifest attribute name field whic…
0be0b57 
…h is only available in Java 9 and fix problems with JARs when manifest already exists
@gunnarmorling gunnarmorling added this to the 1.0.0.Beta2 milestone Oct 3, 2018
@gunnarmorling
Copy link
Member

Fixed.

@gunnarmorling
Copy link
Member

Unfortunately, even though the module-info.class file is now in META-INF, Jandex will still fail to index the JAR, so this feature will not help with that problem.

Yes, that's a known issue. It has been fixed in Jandex some time ago (by simply ignoring all module-info.class files), but I reckon you cannot easily upgrade depending on your environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0.Beta2
Development

No branches or pull requests
2 participants
@gunnarmorling @beikov