Skip to content

Commit

Permalink
feat: f-string for model_name string interpolation
Browse files Browse the repository at this point in the history
  • Loading branch information
asfaltboy committed Jan 23, 2022
1 parent 04ca804 commit a36aa8a
Showing 1 changed file with 8 additions and 4 deletions.
12 changes: 8 additions & 4 deletions advanced_filters/admin.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,16 +22,20 @@ class AdvancedListFilters(admin.SimpleListFilter):

def lookups(self, request, model_admin):
if not model_admin:
raise Exception('Cannot use AdvancedListFilters without a '
'model_admin')
model_name = "{}.{}".format(model_admin.model._meta.app_label,
model_admin.model._meta.object_name)
raise Exception(
"Cannot use AdvancedListFilters without a model_admin"
)
model_name = (
f"{model_admin.model._meta.app_label}."
f"{model_admin.model._meta.object_name}"
)
return AdvancedFilter.objects.filter_by_user(request.user).filter(
model=model_name).values_list('id', 'title')

def queryset(self, request, queryset):
if self.value():
filters = AdvancedFilter.objects.filter(id=self.value())
advfilter = None
if hasattr(filters, 'first'):
advfilter = filters.first()
if not advfilter:
Expand Down

0 comments on commit a36aa8a

Please sign in to comment.