Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Max Channel per Category to 49 #3003

Closed
wants to merge 3 commits into from

Conversation

Coolguy3289
Copy link
Contributor

Addresses #3002
Will add a 1 channel buffer to the check to account for Discord API bugs preventing the category from actually reaching 50 channels.

Addresses modmail-dev#3002
Will add a 1 channel buffer to the check to account for Discord API bugs preventing the category from actually reaching 50 channels.
core/thread.py Outdated Show resolved Hide resolved
Co-authored-by: Jerrie <70805800+Jerrie-Aries@users.noreply.github.com>
@Jerrie-Aries
Copy link
Contributor

Jerrie-Aries commented Apr 22, 2021

Tbh, this PR is not complete yet. I think you need to edit the if statement for fallback category as well.
In thread.py line 1212:

                if fallback and len(fallback.channels) <= 49:

And also about the solution, since it's the glitch/lag on discord side, I'm unsure whether it should be handled in the code here, or in the exception when creating the thread channel.
So, let the devs look at this first.

@fourjr fourjr added the staged Staged for next version label Apr 25, 2021
@fourjr
Copy link
Collaborator

fourjr commented Apr 25, 2021

This PR has been manually merged. Thanks for the contribution.

@fourjr fourjr closed this Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
staged Staged for next version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants