-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clientconfig and babel #140
Comments
I do not understand this issue. Is this a question? Modmore has nothing to do with the website you linked to. |
I asked @funkyduke to report this in case there is something we can do about it. The issue is that clientconfig's new context-aware settings don't work with the recommended babel gateway plugin because of the difference in when they are fired. Switching OnHandleRequest o OnMODXInit in the Babel gateway plugin fixes that. Was hoping the recommended plugin code was in the RTFM or somewhere though, not sure how to go about getting that particular site updated... no idea who runs that. |
This guy owns the domain: https://github.com/mikrobi |
For me this fix does not work? It looks like it 'sees' the correct amount of contexts but doesn't find the data. I set priority of clientconfig OnMODXInit event to 1 and on gateway plugin switched OnHandleRequest to OnMODXInit and set priority to 0. Modx 2.6.1 Any suggestions? This is a very cool feature I would love to use on my site with 4 languages! |
@joyceDesignbase That does not look like the same issue reported here. I think you just need to make sure each of your contexts have a name set (and not just a key). If they do all have a name, please open a separate issue. |
Thank you, that was it! Sorry I didn't know that you had to set a name. |
…n change the event it runs on, if needed [#140]
…th clientConfig (may be even with other plugins) - https://forum.modmore.com/t/clientconfig-not-returning-correct-context-settings/1367 and modmore/ClientConfig#140
I've slightly changed this in 2.3; it will now automatically run on both OnHandleRequest and OnMODXInit events. A little wasteful, because it really only should have to use one, but then I can finally close this and related issues. ;) |
…ClientConfig play nicer with various context routing and other solutions that don't use OnMODXInit [#140]
When following documentation about Babel there's a suggestion to make a gateway-plugin with a System event OnHandleRequest. (http://www.multilingual-modx.com/blog/2011/seo-friendly-multilingual-websites-with-modx-and-babel.html)
But when you work with clientconfig (version 2) then it's better to choose OnModxInit and give it a priority lower than clientconfig.
The text was updated successfully, but these errors were encountered: