Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show pending label when check is pending on GUIv2 #2616

Merged
merged 2 commits into from
Oct 26, 2022

Conversation

Spitfireap
Copy link
Member

Improved UX by showing pending labels on dns details for domain page when status is pending.

see #2614.

@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Merging #2616 (5f7f835) into master (816fa34) will not change coverage.
The diff coverage is n/a.

❗ Current head 5f7f835 differs from pull request most recent head 4d83e96. Consider uploading reports for the commit 4d83e96 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2616   +/-   ##
=======================================
  Coverage   82.42%   82.42%           
=======================================
  Files         211      211           
  Lines       11065    11065           
  Branches     2106     2106           
=======================================
  Hits         9120     9120           
  Misses       1460     1460           
  Partials      485      485           

frontend/src/components/domains/DNSDetail.vue Outdated Show resolved Hide resolved
frontend/src/components/domains/DNSDetail.vue Outdated Show resolved Hide resolved
frontend/src/components/domains/DNSDetail.vue Outdated Show resolved Hide resolved
frontend/src/components/domains/DNSDetail.vue Outdated Show resolved Hide resolved
@Spitfireap Spitfireap marked this pull request as ready for review October 3, 2022 13:15
@tonioo tonioo merged commit e367ed6 into modoboa:master Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants