Offline mode #403
Merged
Offline mode #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geometrically
requested changes
Aug 3, 2023
theseus_gui/src/App.vue
Outdated
| > | ||
| <SearchIcon /> | ||
| </RouterLink> | ||
| <div v-if="!offline"> |
There was a problem hiding this comment.
I don't think we should hide/unhide buttons if the user is offline or not
| @@ -108,7 +113,7 @@ | |||
| <template #disable><XIcon />Disable selected</template> | |||
| <template #enable><CheckCircleIcon />Enable selected</template> | |||
| <template #hide_show><EyeIcon />Show/Hide unselected</template> | |||
| <template #update_all | |||
| <template #update_all v-if="!offline" | |||
There was a problem hiding this comment.
I think it would be better to disable items instead of just hiding them
| <UpdatedIcon v-if="mod.outdated" /> | ||
| <CheckIcon v-else /> | ||
| </Button> | ||
| <div v-if="!offline"> |
There was a problem hiding this comment.
same here, should be disabled rather than hidden
Comment on lines
303
to
312
| // Immediately return to home page if offline | ||
| if (offline.value) { | ||
| await router.push('/') | ||
| } | ||
| const unlisten = await offline_listener((e) => { | ||
| if (e) { | ||
| router.push('/') | ||
| } | ||
| }) | ||
|
|
There was a problem hiding this comment.
same comment with search, don't think this is needed- it can just fail
Geometrically
requested changes
Aug 3, 2023
Geometrically
requested changes
Aug 3, 2023
Geometrically
approved these changes
Aug 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes MOD-462
Fixes #392
Fixes #401