Fix compile warnings #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also some automatic whitespace cleaning.
schmoelder
reviewed
May 14, 2021
|
ODR warnings removed in latest commit thanks to @sleweke / @sleweke-bayer , whichever account applies 😉. For posterity, the ODR warnings were triggered due to forward declarations of |
Removes const qualifiers on returned values, which are without effect.
Fixes warnings encountered when compiling with -Wall -pedantic-errors -Wextra -Wno-unused-parameter -Wno-unused-function. Adds these flags to the standard compile options.
|
I've enabled some more warnings by passing to the compiler. These options are enabled from now on to ensuree code quality. |
Uses std::size_t as loop variable type for iterating std::vector instead of unsigned int.
cadet_assert is only defined in DEBUG mode, leading to unused ptr2 variable. Fixed by only assigning and asserting ptr2 in DEBUG mode.
Since we're comparing with int type.
Sets C++17 as required C++ standard in the CMake script. Also updates the build instructions with the minimum compiler versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #63
We had 3 sets of warnings:
readReferenceConcentrations()declarationsThe first two are fixed. The last one is harder and I'll need help.