Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compile warnings #76

Merged
merged 13 commits into from
Jun 7, 2021
Merged

Fix compile warnings #76

merged 13 commits into from
Jun 7, 2021

Commits on May 14, 2021

  1. Improvement: Fix inline function warning

    @jayghoshter
    jayghoshter committed May 14, 2021
    Configuration menu
    Copy the full SHA
    419ba50 View commit details
    Browse the repository at this point in the history

  2. Fix TBB deprecation warnings. 

    Also some automatic whitespace cleaning.
    @jayghoshter
    jayghoshter committed May 14, 2021
    Configuration menu
    Copy the full SHA
    5e5d3dd View commit details
    Browse the repository at this point in the history

  3. Fix indentation

    @jayghoshter
    jayghoshter committed May 14, 2021
    Configuration menu
    Copy the full SHA
    785fe8c View commit details
    Browse the repository at this point in the history

  4. Remove forward declaration of nlohmann::json to remove ODR warnings

    @jayghoshter
    jayghoshter committed May 14, 2021
    Configuration menu
    Copy the full SHA
    4f3d9c5 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2021

  1. Remove const qualifier on return of values 

    Removes const qualifiers on returned values, which are without effect.
    @sleweke
    sleweke committed May 15, 2021
    Configuration menu
    Copy the full SHA
    e32f137 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2021

  1. Enable and fix more warnings 

    Fixes warnings encountered when compiling with -Wall -pedantic-errors
-Wextra -Wno-unused-parameter -Wno-unused-function. Adds these flags to
the standard compile options.
    @sleweke
    sleweke committed May 16, 2021
    Configuration menu
    Copy the full SHA
    f39f9a1 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2021

  1. Use std::size_t for iterating std::vector 

    Uses std::size_t as loop variable type for iterating std::vector instead
of unsigned int.
    @sleweke
    sleweke committed May 17, 2021
    Configuration menu
    Copy the full SHA
    bbc8ed4 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2021

  1. Remove unused variable warning: gmresResult

    @jayghoshter
    jayghoshter committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    ceb341e View commit details
    Browse the repository at this point in the history

  2. Remove unused variable warnings. 

    cadet_assert is only defined in DEBUG mode, leading to unused ptr2
variable. Fixed by only assigning and asserting ptr2 in DEBUG mode.
    @jayghoshter
    jayghoshter committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    3c7ab94 View commit details
    Browse the repository at this point in the history

  3. Change for-loop index type. Unsigned int to size_t

    @jayghoshter
    jayghoshter committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    6f8a3fb View commit details
    Browse the repository at this point in the history

  4. Add fallthrough decorators.

    @jayghoshter
    jayghoshter committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    cacc37f View commit details
    Browse the repository at this point in the history

  5. Fix for loop index to int. 

    Since we're comparing with int type.
    @jayghoshter
    jayghoshter committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    6752b6b View commit details
    Browse the repository at this point in the history

  6. Require C++17 

    Sets C++17 as required C++ standard in the CMake script. Also updates
the build instructions with the minimum compiler versions.
    @sleweke
    sleweke committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    03b70da View commit details
    Browse the repository at this point in the history