Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Go to definition/reference doesn't work for inout arguments #1901

Closed
soraros opened this issue Mar 6, 2024 · 2 comments
Closed

[BUG]: Go to definition/reference doesn't work for inout arguments #1901

soraros opened this issue Mar 6, 2024 · 2 comments
Assignees
@River707
Labels
bug Something isn't working mojo Issues that are related to mojo mojo-repo Tag all issues with this label mojo-tooling Tag for all issues related to repl, lldb, lsp, vscode extension.

Comments

@soraros
Copy link
Contributor

soraros commented Mar 6, 2024

Bug description

As title.

Steps to reproduce

fn f(inout total: Int):
  total = 0  # cmd click on `total` doesn't work

System information

Mojo 24.1 on Docker, Intel Mac
@soraros soraros added bug Something isn't working mojo Issues that are related to mojo labels Mar 6, 2024
@JoeLoser JoeLoser added the mojo-tooling Tag for all issues related to repl, lldb, lsp, vscode extension. label Mar 8, 2024
@River707
Copy link
Collaborator

Thanks for the report, we'll take a look!

@River707 River707 self-assigned this Apr 1, 2024
@River707
Copy link
Collaborator

River707 commented Apr 1, 2024

Should have a fix for this out by the next release!

@River707 River707 closed this as completed Apr 2, 2024
patrickdoc pushed a commit that referenced this issue May 2, 2024
@River707 @patrickdoc
[mojo-tooling] Fix processing of argument conventions in lsp/docs (#3…
cd1e354 
…6408)

This PR fixes the detection and processing of argument conventions,
allowing properly handling and display of inout/owned/borrowed
arguments (also respecting the defaults for fn vs def).

Closes #1901

MODULAR_ORIG_COMMIT_REV_ID: 83af6de2ec5e2091b3309ef12e5add3eaba2bb34
@ematejska ematejska added the mojo-repo Tag all issues with this label label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@River707 River707

Labels
bug Something isn't working mojo Issues that are related to mojo mojo-repo Tag all issues with this label mojo-tooling Tag for all issues related to repl, lldb, lsp, vscode extension.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@soraros @JoeLoser @ematejska @River707