[stdlib] Replace Pointer by UnsafePointer in stdlib/src/builtin/object.mojo
#2365
+8
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gabrieldemarmiesse <gabrieldemarmiesse@gmail.com>
gabrieldemarmiesse
changed the title
Pointer by UnsafePointer in stdlib/src/builtin/object.mojoPointer by UnsafePointer in stdlib/src/builtin/object.mojo
No concerns from me, I'll merge this later today. We're still working out some custom roles for contributors for merging etc going forward. This will change soon. FYI on this Pointer migration work, I was discussing with @gabrieldemarmiesse offline earlier today and he graciously volunteered to help us out. I mentioned what work we've already done internally that isn't released yet too to avoid duplicate work. Thanks again for helping out here - very much appreciated! |
JoeLoser
approved these changes
Apr 21, 2024
patrickdoc
added a commit
to patrickdoc/mojo
that referenced
this pull request
Apr 24, 2024
…c/builtin/… (#38375) …object.mojo` (modularml#2365) Builtins imports behave in a weird way, I had to import LegacyPointer in `stdlib/src/python/_cpython.mojo`, I have no explanation for this. I just import what the compiler asks me to import :p See https://discord.com/channels/1087530497313357884/1224434323193594059/1231287603462930452 Signed-off-by: gabrieldemarmiesse <gabrieldemarmiesse@gmail.com> mojo-orig-commit: f75add0 Co-authored-by: Gabriel de Marmiesse <gabrieldemarmiesse@gmail.com> modular-orig-commit: c7136f6cc820bcb6e7bed41c1e149bc509f1ccaf
jayzhan211
pushed a commit
to jayzhan211/mojo
that referenced
this pull request
Apr 27, 2024
…c/builtin/… (#38375) …object.mojo` (modularml#2365) Builtins imports behave in a weird way, I had to import LegacyPointer in `stdlib/src/python/_cpython.mojo`, I have no explanation for this. I just import what the compiler asks me to import :p See https://discord.com/channels/1087530497313357884/1224434323193594059/1231287603462930452 Signed-off-by: gabrieldemarmiesse <gabrieldemarmiesse@gmail.com> mojo-orig-commit: f75add0 Co-authored-by: Gabriel de Marmiesse <gabrieldemarmiesse@gmail.com> modular-orig-commit: c7136f6cc820bcb6e7bed41c1e149bc509f1ccaf
patrickdoc
added a commit
to patrickdoc/mojo
that referenced
this pull request
May 2, 2024
…c/builtin/… (#38375) …object.mojo` (modularml#2365) Builtins imports behave in a weird way, I had to import LegacyPointer in `stdlib/src/python/_cpython.mojo`, I have no explanation for this. I just import what the compiler asks me to import :p See https://discord.com/channels/1087530497313357884/1224434323193594059/1231287603462930452 Signed-off-by: gabrieldemarmiesse <gabrieldemarmiesse@gmail.com> mojo-orig-commit: f75add0 Co-authored-by: Gabriel de Marmiesse <gabrieldemarmiesse@gmail.com> MODULAR_ORIG_COMMIT_REV_ID: c7136f6cc820bcb6e7bed41c1e149bc509f1ccaf
patrickdoc
added a commit
that referenced
this pull request
May 2, 2024
…c/builtin/… (#38375) …object.mojo` (#2365) Builtins imports behave in a weird way, I had to import LegacyPointer in `stdlib/src/python/_cpython.mojo`, I have no explanation for this. I just import what the compiler asks me to import :p See https://discord.com/channels/1087530497313357884/1224434323193594059/1231287603462930452 Signed-off-by: gabrieldemarmiesse <gabrieldemarmiesse@gmail.com> mojo-orig-commit: f75add0 Co-authored-by: Gabriel de Marmiesse <gabrieldemarmiesse@gmail.com> MODULAR_ORIG_COMMIT_REV_ID: c7136f6cc820bcb6e7bed41c1e149bc509f1ccaf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builtins imports behave in a weird way, I had to import LegacyPointer in
stdlib/src/python/_cpython.mojo, I have no explanation for this. I just import what the compiler asks me to import :pSee https://discord.com/channels/1087530497313357884/1224434323193594059/1231287603462930452