[stdlib] Consolidate bin and hex internal implementation #2790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
bgreni
force-pushed
the
consolidate-bin-and-hex
branch
from
91d2efb
to
dc4154f
Compare
rparolin
approved these changes
May 27, 2024
|
!sync |
modularbot
added
the
imported-internally
bgreni
force-pushed
the
consolidate-bin-and-hex
branch
from
dc4154f
to
34ddaa0
Compare
Signed-off-by: Brian Grenier <grenierb96@gmail.com>
bgreni
force-pushed
the
consolidate-bin-and-hex
branch
from
34ddaa0
to
c6f159f
Compare
|
✅🟣 This contribution has been merged 🟣✅ Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the nightly branch during the next Mojo nightly release, typically within the next 24-48 hours. We use Copybara to merge external contributions, click here to learn more. |
modularbot
added
the
merged-internally
modularbot
pushed a commit
that referenced
this pull request
May 31, 2024
…#40690) [External] [stdlib] Consolidate bin and hex internal implementation Fixes #2730 - Utilize `_format_int` for for both `bin` and `hex` - Support `SIMD` and `Indexer` types for `hex` - Move implementations into `format_int` module --------- Co-authored-by: bgreni <42788181+bgreni@users.noreply.github.com> Co-authored-by: Rob Parolin <rparolin@modular.com> Closes #2790 MODULAR_ORIG_COMMIT_REV_ID: 0d5c716cb884468c8d3d49ac585115c39f131880
|
Landed in 2729b02! Thank you for your contribution 🎉 |
modularbot
pushed a commit
that referenced
this pull request
Jun 7, 2024
…#40690) [External] [stdlib] Consolidate bin and hex internal implementation Fixes #2730 - Utilize `_format_int` for for both `bin` and `hex` - Support `SIMD` and `Indexer` types for `hex` - Move implementations into `format_int` module --------- Co-authored-by: bgreni <42788181+bgreni@users.noreply.github.com> Co-authored-by: Rob Parolin <rparolin@modular.com> Closes #2790 MODULAR_ORIG_COMMIT_REV_ID: 0d5c716cb884468c8d3d49ac585115c39f131880
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2730
_format_intfor for bothbinandhexSIMDandIndexertypes forhexformat_intmodule