Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Update UnsafePointer APIs in pointers.ipynb #3080

Closed
wants to merge 2 commits into from

Conversation

codingonion
Copy link

Fix typo in pointers.ipynb

Signed-off-by: codingonion <coderonion@gmail.com>
@codingonion codingonion requested a review from a team as a code owner June 19, 2024 15:06
Copy link
Collaborator

@arthurevans arthurevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Definitely more than a typo fix, so I'm going to update the PR title accordingly.

@arthurevans arthurevans changed the title [docs] Fix typo in pointers.ipynb [docs] Update UnsafePointer APIs in pointers.ipynb Jun 20, 2024
@arthurevans
Copy link
Collaborator

!sync

@modularbot modularbot added the imported-internally Signals that a given pull request has been imported internally. label Jun 20, 2024
@modularbot
Copy link
Collaborator

✅🟣 This contribution has been merged 🟣✅

Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the nightly branch during the next Mojo nightly release, typically within the next 24-48 hours.

We use Copybara to merge external contributions, click here to learn more.

@modularbot modularbot added the merged-internally Indicates that this pull request has been merged internally label Jun 20, 2024
@modularbot modularbot added the merged-externally Merged externally in public mojo repo label Jun 21, 2024
modularbot pushed a commit that referenced this pull request Jun 21, 2024
[External] [docs] Update UnsafePointer APIs in pointers.ipynb

Fix typo in pointers.ipynb

Co-authored-by: codingonion <coderonion@gmail.com>
Closes #3080
MODULAR_ORIG_COMMIT_REV_ID: 576d18f0234b28daa464102859b8a0449194f100
@modularbot
Copy link
Collaborator

Landed in 0496a99! Thank you for your contribution 🎉

@modularbot modularbot closed this Jun 21, 2024
modularbot pushed a commit that referenced this pull request Jun 21, 2024
Follow-up to #3080, updating the
diagram and some wording to match the new UnsafePointer APIs.

MODULAR_ORIG_COMMIT_REV_ID: 01d145d8a4dbba6471fc03dd199d7bdad6fcd3c3
@codingonion codingonion deleted the my-fix-pr branch June 22, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
imported-internally Signals that a given pull request has been imported internally. merged-externally Merged externally in public mojo repo merged-internally Indicates that this pull request has been merged internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants